From 2583b692d596fc62d4de1e6fbc9569bc26bebff4 Mon Sep 17 00:00:00 2001
From: Alex Shinn <ashinn@users.noreply.github.com>
Date: Fri, 18 Dec 2009 14:16:10 +0900
Subject: [PATCH] disasm now recursively prints lets and local lambdas

---
 TODO                 |  6 ++++--
 opt/debug.c          | 44 ++++++++++++++++++++++++++++++++++++--------
 tests/r5rs-tests.scm | 12 ++++++++++++
 3 files changed, 52 insertions(+), 10 deletions(-)

diff --git a/TODO b/TODO
index 4fd8e131..0468bee3 100644
--- a/TODO
+++ b/TODO
@@ -18,7 +18,8 @@
 * compiler optimizations
 ** DONE constant folding
    - State "DONE"       [2009-12-16 Wed 23:25]
-** TODO simplification pass, dead-code elimination
+** DONE simplification pass, dead-code elimination
+   - State "DONE"       [2009-12-18 Fri 14:14]
    This is important in particular for the output generated by
    syntax-rules.
 ** TODO lambda lift
@@ -60,7 +61,8 @@
    - State "DONE"       [2009-07-07 Tue 14:42]
 ** TODO unicode
 ** TODO threads
-** TODO recursive disasm
+** DONE recursive disasm
+   - State "DONE"       [2009-12-18 Fri 14:15]
 
 * FFI
 ** DONE libdl support
diff --git a/opt/debug.c b/opt/debug.c
index 97d46d7b..4d0631f2 100644
--- a/opt/debug.c
+++ b/opt/debug.c
@@ -2,6 +2,9 @@
 /*  Copyright (c) 2009 Alex Shinn.  All rights reserved. */
 /*  BSD-style license: http://synthcode.com/license.txt  */
 
+#define SEXP_DISASM_MAX_DEPTH 8
+#define SEXP_DISASM_PAD_WIDTH 4
+
 static const char* reverse_opcode_names[] =
   {"NOOP", "RAISE", "RESUMECC", "CALLCC", "APPLY1", "TAIL-CALL", "CALL",
    "FCALL0", "FCALL1", "FCALL2", "FCALL3", "FCALL4", "FCALL5", "FCALL6",
@@ -18,8 +21,10 @@ static const char* reverse_opcode_names[] =
    "WRITE-CHAR", "NEWLINE", "READ-CHAR", "PEEK-CHAR", "RET", "DONE",
   };
 
-static sexp sexp_disasm (sexp ctx, sexp bc, sexp out) {
-  unsigned char *ip, opcode;
+static sexp disasm (sexp ctx, sexp bc, sexp out, int depth) {
+  sexp tmp;
+  unsigned char *ip, opcode, i;
+
   if (sexp_procedurep(bc)) {
     bc = sexp_procedure_code(bc);
   } else if (sexp_opcodep(bc)) {
@@ -30,12 +35,21 @@ static sexp sexp_disasm (sexp ctx, sexp bc, sexp out) {
   }
   if (! sexp_oportp(out))
     return SEXP_VOID;
-  ip = sexp_bytecode_data(bc);
+
+  for (i=0; i<(depth*SEXP_DISASM_PAD_WIDTH); i++)
+    sexp_write_char(ctx, ' ', out);
   sexp_write_string(ctx, "-------------- ", out);
-  if (sexp_truep(sexp_bytecode_name(bc)))
+  if (sexp_truep(sexp_bytecode_name(bc))) {
     sexp_write(ctx, sexp_bytecode_name(bc), out);
-  sexp_write_char(ctx, '\n', out);
+    sexp_write_char(ctx, ' ', out);
+  }
+  sexp_printf(ctx, out, "%p\n", bc);
+
+  ip = sexp_bytecode_data(bc);
+
  loop:
+  for (i=0; i<(depth*SEXP_DISASM_PAD_WIDTH); i++)
+    sexp_write_char(ctx, ' ', out);
   opcode = *ip++;
   if (opcode*sizeof(char*) < sizeof(reverse_opcode_names)) {
     sexp_printf(ctx, out, "  %s ", reverse_opcode_names[opcode]);
@@ -54,11 +68,12 @@ static sexp sexp_disasm (sexp ctx, sexp bc, sexp out) {
   case OP_FCALL1:
   case OP_FCALL2:
   case OP_FCALL3:
+  case OP_FCALL4:
+  case OP_FCALL5:
+  case OP_FCALL6:
     sexp_printf(ctx, out, "%ld", (sexp_sint_t) ((sexp*)ip)[0]);
     ip += sizeof(sexp);
     break;
-    ip += sizeof(sexp);
-    break;
   case OP_SLOT_REF:
   case OP_SLOT_SET:
   case OP_MAKE:
@@ -69,16 +84,29 @@ static sexp sexp_disasm (sexp ctx, sexp bc, sexp out) {
   case OP_TAIL_CALL:
   case OP_CALL:
   case OP_PUSH:
-    sexp_write(ctx, ((sexp*)ip)[0], out);
+    tmp = ((sexp*)ip)[0];
+    if (((opcode == OP_GLOBAL_REF) || (opcode == OP_GLOBAL_KNOWN_REF))
+        && sexp_pairp(tmp))
+      tmp = sexp_car(tmp);
+    else if ((opcode == OP_PUSH) && (sexp_pairp(tmp) || sexp_idp(tmp)))
+      sexp_write_char(ctx, '\'', out);
+    sexp_write(ctx, tmp, out);
     ip += sizeof(sexp);
     break;
   }
   sexp_write_char(ctx, '\n', out);
+  if ((opcode == OP_PUSH) && (depth < SEXP_DISASM_MAX_DEPTH)
+      && (sexp_bytecodep(tmp) || sexp_procedurep(tmp)))
+    disasm(ctx, tmp, out, depth+1);
   if (ip - sexp_bytecode_data(bc) < sexp_bytecode_length(bc))
     goto loop;
   return SEXP_VOID;
 }
 
+static sexp sexp_disasm (sexp ctx, sexp bc, sexp out) {
+  return disasm(ctx, bc, out, 0);
+}
+
 #if USE_DEBUG_VM
 static void sexp_print_stack (sexp ctx, sexp *stack, int top, int fp, sexp out) {
   int i;
diff --git a/tests/r5rs-tests.scm b/tests/r5rs-tests.scm
index 555caf85..1a2091d6 100644
--- a/tests/r5rs-tests.scm
+++ b/tests/r5rs-tests.scm
@@ -424,6 +424,18 @@
               (define internal-def 'ok))
             internal-def))
 
+(test '(2 1)
+    ((lambda () (let ((x 1)) (let ((y x)) (set! x 2) (list x y))))))
+
+(test '(2 2)
+    ((lambda () (let ((x 1)) (set! x 2) (let ((y x)) (list x y))))))
+
+(test '(1 2)
+    ((lambda () (let ((x 1)) (let ((y x)) (set! y 2) (list x y))))))
+
+(test '(2 3)
+    ((lambda () (let ((x 1)) (let ((y x)) (set! x 2) (set! y 3) (list x y))))))
+
 ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
 
 (test-report)