Fcalva/cyclone
1
0
Fork 0
mirror of https://github.com/justinethier/cyclone.git synced 2025-07-15 16:57:35 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Tweaked GC thresholds

Browse source
This commit is contained in:
Justin Ethier 2015-12-10 21:48:19 -05:00
parent be9a07551e
commit 29e6cb38e9
1 changed files with 18 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

33
gc.c
View file

@ -821,13 +821,15 @@ void gc_mut_cooperate(gc_thread_data *thd, int buf_len)
} }
#endif #endif
// Initiate collection cycle if free space is too low // Initiate collection cycle if free space is too low.
// Threshold is intentially low because we have to go through an
// entire handshake/trace/sweep cycle, ideally without growing heap.
if (stage == STAGE_RESTING && if (stage == STAGE_RESTING &&
(cached_heap_free_size < (cached_heap_total_size * 0.10))){ (cached_heap_free_size < (cached_heap_total_size * 0.50))){
fprintf(stdout, "Less than 10%% of the heap is free, initiating collector\n"); // Temporary debug line #if GC_DEBUG_TRACE
ATOMIC_SET_IF_EQ(&gc_stage, fprintf(stdout, "Less than 50%% of the heap is free, initiating collector\n");
STAGE_RESTING, #endif
STAGE_CLEAR_OR_MARKING); ATOMIC_SET_IF_EQ(&gc_stage, STAGE_RESTING, STAGE_CLEAR_OR_MARKING);
} }
} }
@ -1102,9 +1104,9 @@ void gc_collector()
{ {
int old_clear, old_mark; int old_clear, old_mark;
size_t freed = 0, max_freed = 0, total_size, total_free; size_t freed = 0, max_freed = 0, total_size, total_free;
//#if GC_DEBUG_TRACE #if GC_DEBUG_TRACE
time_t sweep_start = time(NULL); time_t sweep_start = time(NULL);
//#endif #endif
//clear : //clear :
ATOMIC_SET_IF_EQ(&gc_stage, STAGE_RESTING, STAGE_CLEAR_OR_MARKING); ATOMIC_SET_IF_EQ(&gc_stage, STAGE_RESTING, STAGE_CLEAR_OR_MARKING);
// exchange values of markColor and clearColor // exchange values of markColor and clearColor
@ -1148,16 +1150,17 @@ fprintf(stderr, "DEBUG - after wait_handshake async\n");
total_free = cached_heap_free_size; //gc_heap_total_free_size(gc_get_heap()); total_free = cached_heap_free_size; //gc_heap_total_free_size(gc_get_heap());
if (total_free < (total_size * 0.10)) { if (total_free < (total_size * 0.10)) {
fprintf(stdout, "JAE TODO: may need to rethink this growth strategy\n"); #if GC_DEBUG_TRACE
fprintf(stdout, "Less than 10%% of the heap is free, growing it\n", fprintf(stdout, "Less than 10%% of the heap is free, growing it\n",
total_free, total_size); total_free, total_size);
#endif
gc_grow_heap(gc_get_heap(), 0, 0); gc_grow_heap(gc_get_heap(), 0, 0);
} }
//#if GC_DEBUG_TRACE #if GC_DEBUG_TRACE
fprintf(stderr, "sweep done, total_size = %d, total_free = %d, freed = %d, max_freed = %d, elapsed = %ld\n", fprintf(stderr, "sweep done, total_size = %d, total_free = %d, freed = %d, max_freed = %d, elapsed = %ld\n",
total_size, total_free, total_size, total_free,
freed, max_freed, time(NULL) - sweep_start); freed, max_freed, time(NULL) - sweep_start);
//#endif #endif
ATOMIC_SET_IF_EQ(&gc_stage, STAGE_SWEEPING, STAGE_RESTING); ATOMIC_SET_IF_EQ(&gc_stage, STAGE_SWEEPING, STAGE_RESTING);
} }
@ -1166,9 +1169,9 @@ void *collector_main(void *arg)
int stage; int stage;
struct timespec tim; struct timespec tim;
tim.tv_sec = 0; tim.tv_sec = 0;
JAE TODO: this is still not good enough, seems memory grows still grows fast with this. //JAE TODO: this is still not good enough, seems memory grows still grows fast with this.
alternatively, may want to consider shrinking the heap if possible after a collection, if it is //alternatively, may want to consider shrinking the heap if possible after a collection, if it is
sparse enough (would be difficult to do without relocations, though //sparse enough (would be difficult to do without relocations, though
tim.tv_nsec = 100 * NANOSECONDS_PER_MILLISECOND; tim.tv_nsec = 100 * NANOSECONDS_PER_MILLISECOND;
while (1) { while (1) {
stage = ATOMIC_GET(&gc_stage); stage = ATOMIC_GET(&gc_stage);