Fcalva/cyclone
1
0
Fork 0
mirror of https://github.com/justinethier/cyclone.git synced 2025-07-15 16:57:35 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Added notes

Browse source
This commit is contained in:
Justin Ethier 2015-10-29 18:43:21 -04:00
parent 1becf84a47
commit 40f2ac6207
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
gc.c
View file

@ -493,7 +493,10 @@ void gc_mut_cooperate(gc_thread_data *thd)
// Collector functions // Collector functions
void gc_mark_gray(gc_thread_data *thd, object obj) void gc_mark_gray(gc_thread_data *thd, object obj)
{ {
if (is_object_type(obj) && mark(obj) == gc_color_clear) { // TODO: sync?? // sync access to obj? check the paper, need to see if any other thread would be modifying
// either object type or mark. I believe both should be stable once the object is placed
// into the heap, with the collector being the only thread that changes marks. but double-check.
if (is_object_type(obj) && mark(obj) == ATOMIC_GET(&gc_color_clear)) { // TODO: sync??
// TODO: lock mark buffer (not ideal, but a possible first step)? // TODO: lock mark buffer (not ideal, but a possible first step)?
// pthread_mutex_lock // pthread_mutex_lock
thd->mark_buffer = vpbuffer_add(thd->mark_buffer, thd->mark_buffer = vpbuffer_add(thd->mark_buffer,
@ -508,7 +511,7 @@ void gc_mark_gray(gc_thread_data *thd, object obj)
void gc_col_mark_gray(object obj) void gc_col_mark_gray(object obj)
{ {
if (is_object_type(obj) && mark(obj) == gc_color_clear) { // TODO: sync?? if (is_object_type(obj) && mark(obj) == ATOMIC_GET(&gc_color_clear)) {
mark_stack = vpbuffer_add(mark_stack, &mark_stack_len, mark_stack_i++, obj); mark_stack = vpbuffer_add(mark_stack, &mark_stack_len, mark_stack_i++, obj);
} }
} }