Fcalva/cyclone
1
0
Fork 0
mirror of https://github.com/justinethier/cyclone.git synced 2025-07-13 07:47:39 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

WIP: remove locking from GC collector's trace

Browse source
This commit is contained in:
Justin Ethier 2018-06-11 18:58:33 -04:00
parent f9fa7d9214
commit 74d53eb334
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
gc.c
View file

@ -1836,7 +1836,7 @@ void gc_collector_trace()
CK_ARRAY_FOREACH(&Cyc_mutators, &iterator, &m) { CK_ARRAY_FOREACH(&Cyc_mutators, &iterator, &m) {
// TODO: ideally, want to use a lock-free data structure to prevent // TODO: ideally, want to use a lock-free data structure to prevent
// having to use a mutex here. see corresponding code in gc_mark_gray // having to use a mutex here. see corresponding code in gc_mark_gray
pthread_mutex_lock(&(m->lock)); //pthread_mutex_lock(&(m->lock));
while (m->last_read < m->last_write) { while (m->last_read < m->last_write) {
clean = 0; clean = 0;
#if GC_DEBUG_VERBOSE #if GC_DEBUG_VERBOSE
@ -1848,13 +1848,13 @@ void gc_collector_trace()
gc_empty_collector_stack(); gc_empty_collector_stack();
(m->last_read)++; // Inc here to prevent off-by-one error (m->last_read)++; // Inc here to prevent off-by-one error
} }
pthread_mutex_unlock(&(m->lock)); //pthread_mutex_unlock(&(m->lock));
// Try checking the condition once more after giving the // Try checking the condition once more after giving the
// mutator a chance to respond, to prevent exiting early. // mutator a chance to respond, to prevent exiting early.
// This is experimental, not sure if it is necessary // This is experimental, not sure if it is necessary
if (clean) { if (clean) {
pthread_mutex_lock(&(m->lock)); //pthread_mutex_lock(&(m->lock));
if (m->last_read < m->last_write) { if (m->last_read < m->last_write) {
#if GC_SAFETY_CHECKS #if GC_SAFETY_CHECKS
fprintf(stderr, fprintf(stderr,
@ -1864,7 +1864,7 @@ void gc_collector_trace()
} else if (m->pending_writes) { } else if (m->pending_writes) {
clean = 0; clean = 0;
} }
pthread_mutex_unlock(&(m->lock)); //pthread_mutex_unlock(&(m->lock));
} }
} }
} }