Fcalva/cyclone
1
0
Fork 0
mirror of https://github.com/justinethier/cyclone.git synced 2025-05-23 20:15:05 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Issue #6 - Only GC mutated vector element

Browse source 
Make the minor GC write barrie more efficient by only moving the mutated element of a vector, rather than all elements. Unfortunately this does not make a large improvement in performance, but it seems to help a bit.
This commit is contained in:
Justin Ethier 2016-04-08 23:17:03 -04:00
parent e21d624371
commit a5c7f69377
2 changed files with 20 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
include/cyclone/types.h
View file

@ -438,7 +438,7 @@ void gc_mutator_thread_runnable(gc_thread_data *thd, object result);
gc_heap *gc_get_heap();
int gc_minor(void *data, object low_limit, object high_limit, closure cont, object *args, int num_args);
/* Mutation table to support minor GC write barrier */
void add_mutation(void *data, object var, object value);
void add_mutation(void *data, object var, int index, object value);
void clear_mutations(void *data);
#endif /* CYCLONE_TYPES_H */

30
runtime.c
View file

@ -324,9 +324,14 @@ void debug_dump_globals()
* the calling thread, so locking is not required.
*/
void add_mutation(void *data, object var, object value){
void add_mutation(void *data, object var, int index, object value){
gc_thread_data *thd = (gc_thread_data *)data;
if (is_object_type(value)) {
if (index >= 0) {
// For vectors only, mcons index as another var. That way
// the write barrier only needs to inspect the mutated index.
thd->mutations = mcons(obj_int2obj(index), thd->mutations);
}
thd->mutations = mcons(var, thd->mutations);
}
}
@ -969,7 +974,7 @@ object Cyc_set_car(void *data, object l, object val) {
if (Cyc_is_cons(l) == boolean_f) Cyc_invalid_type_error(data, cons_tag, l);
gc_mut_update((gc_thread_data *)data, car(l), val);
car(l) = val;
add_mutation(data, l, val);
add_mutation(data, l, -1, val);
return l;
}
@ -977,7 +982,7 @@ object Cyc_set_cdr(void *data, object l, object val) {
if (Cyc_is_cons(l) == boolean_f) Cyc_invalid_type_error(data, cons_tag, l);
gc_mut_update((gc_thread_data *)data, cdr(l), val);
cdr(l) = val;
add_mutation(data, l, val);
add_mutation(data, l, -1, val);
return l;
}
@ -996,9 +1001,7 @@ object Cyc_vector_set(void *data, object v, object k, object obj) {
obj);
((vector)v)->elts[idx] = obj;
// TODO: probably could be more efficient here and also pass
// index, so only that one entry needs GC.
add_mutation(data, v, obj);
add_mutation(data, v, idx, obj);
return v;
}
@ -2847,15 +2850,20 @@ int gc_minor(void *data, object low_limit, object high_limit, closure cont, obje
list l;
for (l = ((gc_thread_data *)data)->mutations; !nullp(l); l = cdr(l)) {
object o = car(l);
if (type_of(o) == cons_tag) {
if (is_value_type(o)) {
// Can happen if a vector element was already
// moved and we found an index. Just ignore it
} else if (type_of(o) == cons_tag) {
gc_move2heap(car(o));
gc_move2heap(cdr(o));
} else if (type_of(o) == vector_tag) {
int i;
// TODO: probably too inefficient, try collecting single index
for (i = 0; i < ((vector)o)->num_elt; i++) {
int i;
object idx;
// For vectors, index is encoded as the next mutation
l = cdr(l);
idx = car(l);
i = obj_obj2int(idx);
gc_move2heap(((vector)o)->elts[i]);
}
} else if (type_of(o) == forward_tag) {
// Already transported, skip
} else {