From ae46e39c45365cfd07a4ddb513c6c0b6ad8d1afd Mon Sep 17 00:00:00 2001
From: Justin Ethier <justin.ethier@gmail.com>
Date: Tue, 1 Dec 2015 00:22:54 -0500
Subject: [PATCH] Added TODO

---
 gc.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/gc.c b/gc.c
index bdce29ae..2761bc18 100644
--- a/gc.c
+++ b/gc.c
@@ -932,6 +932,12 @@ void gc_collector_trace()
       while (m->last_read < m->last_write) {
         clean = 0;
         (m->last_read)++;
+TODO: I think there is an off-by-one error here. inspect last read/write.
+is the code going one too many? per paper it is not, but based on
+logs it looks like it is reading past end of buffer. (ie, errors always seem
+to be on the last object traced, and checking the history, an object
+incorrectly marked at position X can be seen to have been stored at position
+X in a previous collection.
 printf("gc_mark_black mark buffer %p, last_read = %d last_write = %d\n", 
 (m->mark_buffer)[m->last_read],
 m->last_read, m->last_write);