Fcalva/cyclone
1
0
Fork 0
mirror of https://github.com/justinethier/cyclone.git synced 2025-07-15 08:47:35 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix off-by-one errors

Browse source
This commit is contained in:
Justin Ethier 2021-03-12 15:04:35 -05:00
parent 4878149af0
commit c2274aed52
1 changed files with 8 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
runtime.c
View file

@ -3055,16 +3055,17 @@ object Cyc_make_bytevector(void *data, object cont, int argc, object len, ...)
// carg TODO: need to test each of these "dispatch" functions for // carg TODO: need to test each of these "dispatch" functions for
// off-by-one errors! I think there are bugs in each of them // off-by-one errors! I think there are bugs in each of them
void dispatch_bytevector(void *data, object clo, int _argc, object *args) void dispatch_bytevector(void *data, object clo, int _argc, object *_args)
{ {
int argc = _argc - 1; int argc = _argc - 1; // Skip continuation
object *args = _args + 1; // Skip continuation
int i, val; int i, val;
object tmp; object tmp;
char *buffer; char *buffer;
make_empty_bytevector(bv); make_empty_bytevector(bv);
if (argc > 0) { if (argc > 0) {
buffer = alloca(sizeof(char) * argc); buffer = alloca(sizeof(char) * argc);
for(i = 1; i < argc; i++) { for(i = 0; i < argc; i++) {
tmp = args[i]; tmp = args[i];
Cyc_check_num(data, tmp); Cyc_check_num(data, tmp);
val = unbox_number(tmp); val = unbox_number(tmp);
@ -3102,9 +3103,10 @@ object Cyc_bytevector(void *data, object cont, int argc, object bval, ...)
_return_closcall1(data, cont, &bv); _return_closcall1(data, cont, &bv);
} }
void dispatch_bytevector_91append(void *data, object clo, int _argc, object *args) void dispatch_bytevector_91append(void *data, object clo, int _argc, object *_args)
{ {
int argc = _argc - 1; int argc = _argc - 1; // Skip continuation
object *args = _args + 1; // Skip continuation
int i = 0, buf_idx = 0, total_length = 0; int i = 0, buf_idx = 0, total_length = 0;
object tmp; object tmp;
char *buffer; char *buffer;
@ -3114,7 +3116,7 @@ void dispatch_bytevector_91append(void *data, object clo, int _argc, object *arg
if (argc > 0) { if (argc > 0) {
buffers = alloca(sizeof(char *) * argc); buffers = alloca(sizeof(char *) * argc);
lengths = alloca(sizeof(int) * argc); lengths = alloca(sizeof(int) * argc);
for(i = 1; i < argc; i++) { for(i = 0; i < argc; i++) {
tmp = args[i]; tmp = args[i];
Cyc_check_bvec(data, tmp); Cyc_check_bvec(data, tmp);
total_length += ((bytevector)tmp)->len; total_length += ((bytevector)tmp)->len;